fix(audit): correct type-narrowing in the emit-coverage spec#705
Merged
Conversation
The stale-entry filter passed a possibly-undefined key into isEmitted. The full-program typecheck (tsconfig.json, which includes specs) flags that, but the build typecheck (tsconfig.build.json, which excludes specs) did not -- so CI went red once the coverage gate merged. isEmitted now accepts undefined and short-circuits, closing the narrowing gap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red: the audit-coverage spec (from the emit-coverage gate) passed a possibly-undefined key into
isEmitted, which the full-program typecheck (tsconfig.json, includes specs) rejects but the build typecheck (tsconfig.build.json, excludes specs) missed.isEmittednow acceptsundefinedand short-circuits. Verified withtsc --noEmit -p tsconfig.json(the exact CI command) + the 25 spec tests.