Simplify framebuffer_mixin by removing deprecation notice#423
Merged
Conversation
Removed deprecation warning for string framebuffer in framebuffer_mixin.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes deprecated string framebuffer support and its associated warning from the __framebuffer_mixin class. The review feedback suggests that since the deprecation period has ended, the entire mixin class is now redundant and should be removed from the codebase. Alternatively, if the mixin is retained, the init_framebuffer method can be simplified using a single-line fallback.
Simplified framebuffer initialization logic by using a single line conditional assignment.
thijstriemstra
approved these changes
May 26, 2026
thijstriemstra
left a comment
thijstriemstra
left a comment
Collaborator
There was a problem hiding this comment.
thanks. if you can also update the license year in the file and add a changelog entry and it's good to go.
Add parameter documentation for init_framebuffer method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed deprecation warning for string framebuffer in framebuffer_mixin.
Fixes #422