fix(path): add ERR_INVALID_ARG_TYPE code to path polyfill errors#65
Open
atharvasingh7007 wants to merge 1 commit intorivet-dev:mainfrom
Open
fix(path): add ERR_INVALID_ARG_TYPE code to path polyfill errors#65atharvasingh7007 wants to merge 1 commit intorivet-dev:mainfrom
atharvasingh7007 wants to merge 1 commit intorivet-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #28 (partially - path module only)
Upstream Node.js errors from built-in modules carry a .code property (e.g., ERR_INVALID_ARG_TYPE). The path module polyfill (backed by path-browserify) throws plain TypeError without this code property, causing conformance test failures.
This PR adds a custom path polyfill wrapper that intercepts TypeError exceptions from path-browserify and attaches the missing error.code = "ERR_INVALID_ARG_TYPE" before re-throwing.
Changes
How it works
Testing
Scope
This PR addresses Issue #28 for the path module only. The remaining affected modules (assert, buffer, url, querystring, util, fs) can be handled in follow-up PRs using the same wrapper pattern.