test: add fixCleanup3_1_3 to NOT_ON_MAINNET exceptions#40
Open
shichengripple001 wants to merge 4 commits into
Open
test: add fixCleanup3_1_3 to NOT_ON_MAINNET exceptions#40shichengripple001 wants to merge 4 commits into
shichengripple001 wants to merge 4 commits into
Conversation
New amendment introduced in rippled 3.1.3 is not yet enabled on mainnet. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Fix multiline --body string using heredoc, and run on 1st and 15th of each month instead of monthly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Heredoc content has zero indentation which terminates the YAML block scalar early. Replace with echo statements into a temp file and use --body-file instead of --body. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The XRPL account_tx RPC treats limit as a hint and can return more results than requested. Slice the response array to enforce the limit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixCleanup3_1_3is a new amendment introduced in rippled 3.1.3 that is not yet enabled on mainnetNOT_ON_MAINNETexceptions set in the amendment test to stop the false failureTest plan
npx vitest run --config vitest.config.local.ts tests/e2e/sandbox/amendment.test.tspasses (10/10 tests)🤖 Generated with Claude Code