Skip to content

feat(validators): display base_fee in drops on Fee Voting table (#1206) #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmchow wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(validators): display base_fee in drops on Fee Voting table (#1206) #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
329378c
feat(validators): display base_fee in drops on Fee Voting table
tmchow Apr 23, 2026
2cf8686
chore(i18n): add drops key placeholders for non-English locales
tmchow May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/locales/ca-CA/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@
"missed_validations": "{{count}} validacions perdudes",
"incomplete": "incomplet",
"base_fee": "Comissío Base",
"drops": null,
"account_reserve": "Reserva de Compte",
"object_reserve": "Reserva d'Objectes",
"vote": "Vota",
Expand Down
1 change: 1 addition & 0 deletions public/locales/en-US/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@
"missed_validations": "{{count}} missed validations",
"incomplete": "incomplete",
"base_fee": "Base Fee",
"drops": "drops",

@mvadari mvadari May 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the null keys in the other languages

@tmchow tmchow May 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 2cf8686. Added "drops": null to ja-JP, ko-KR, es-ES, fr-FR, ca-CA, and my-MM right after each locale's base_fee key. They keep falling back to the en-US string via fallbackLng: 'en-US' until translations land.

"account_reserve": "Account Reserve",
"object_reserve": "Object Reserve",
"vote": "Vote",
Expand Down
1 change: 1 addition & 0 deletions public/locales/es-ES/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@
"missed_validations": "{{count}} validaciones perdidas",
"incomplete": "incompleto",
"base_fee": null,
"drops": null,
"account_reserve": null,
"object_reserve": null,
"vote": null,
Expand Down
1 change: 1 addition & 0 deletions public/locales/fr-FR/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@
"missed_validations": "{{count}} validations manquées",
"incomplete": "incomplet",
"base_fee": null,
"drops": null,
"account_reserve": null,
"object_reserve": null,
"vote": null,
Expand Down
1 change: 1 addition & 0 deletions public/locales/ja-JP/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@
"missed_validations": "バリデーション失敗数:{{count}}",
"incomplete": null,
"base_fee": "基本手数料",
"drops": null,
"account_reserve": "アカウント準備金",
"object_reserve": "オブジェクト準備金",
"vote": "投票",
Expand Down
1 change: 1 addition & 0 deletions public/locales/ko-KR/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@
"missed_validations": "{{count}}회의 유효성 검증이 누락되었습니다",
"incomplete": "미완료",
"base_fee": null,
"drops": null,
"account_reserve": null,
"object_reserve": null,
"vote": null,
Expand Down
1 change: 1 addition & 0 deletions public/locales/my-MM/translations.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,7 @@
"missed_validations": "{{count}} ခု အတည်ပြုမှု လွဲချော်",
"incomplete": "မပြီးပြည့်စုံ",
"base_fee": "အခြေခံ အခကြေးငွေ",
"drops": null,
"account_reserve": "အကောင့် သီးသန့်ငွေ",
"object_reserve": "အရာဝတ္ထု သီးသန့်ငွေ",
"vote": "မဲပေးရန်",
Expand Down
6 changes: 5 additions & 1 deletion src/containers/Network/ValidatorsTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,11 @@ export const ValidatorsTable = (props: ValidatorsTableProps) => {
<DownIcon className="fee-icon" title={pubkey} alt={pubkey} />
</span>
))}
<span>{renderXRP(data / DROPS_TO_XRP_FACTOR, language)}</span>
{className === 'base_fee' ? (
<span>{`${data} ${t('drops')}`}</span>
) : (
<span>{renderXRP(data / DROPS_TO_XRP_FACTOR, language)}</span>
)}
</td>
) : (
<td className={`${className} vote`} />
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Network/test/validatorsTable.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('Validators table', () => {
'0.20',
)
expect(container.querySelector('td.base_fee').textContent.trim()).toContain(
'0.00001',
'10 drops',
)
})
})
2 changes: 1 addition & 1 deletion src/containers/Validators/VotingTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export const VotingTab: FC<{
<div className="metrics metrics-voting">
<div className="cell">
<div className="label">{t('base_fee')}</div>
<div>{renderXRP(validatorData.base_fee / XRP_BASE)}</div>
<div>{`${validatorData.base_fee} ${t('drops')}`}</div>
</div>
<div className="cell">
<div className="label">{t('account_reserve')}</div>
Expand Down
2 changes: 1 addition & 1 deletion src/containers/Validators/test/VotingTab.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describe('VotingTab container', () => {

// Render fees voting correctly
const cells = container.querySelectorAll('.metrics .cell')
expect(cells[0].innerHTML).toContain('0.00001')
expect(cells[0].innerHTML).toContain('10 drops')
expect(cells[1].innerHTML).toContain('10.00')
expect(cells[2].innerHTML).toContain('2.00')

Expand Down