Skip to content

Fix/missing keyboard navigation - #183

Merged
RUKAYAT-CODER merged 7 commits into
rinafcode:mainfrom
MerlinTheWhiz:fix/missing-keyboard-navigation
Apr 25, 2026
Merged

RUKAYAT-CODER merged 7 commits into
rinafcode:mainfrom
MerlinTheWhiz:fix/missing-keyboard-navigation

Conversation

@MerlinTheWhiz

Copy link
Copy Markdown
Contributor

Closes #128

Changes I made:

  • Add role="button" and tabIndex={0} to non-semantic interactive elements
  • Implement keyboard support via onKeyDown (Enter & Space activation)
  • Apply consistent Tailwind focus styles (focus:outline-none focus:ring-2 ...) across interactive components
  • Enhance accessibility for notification items, transcript rows, cards, uploaders, and video controls

@drips-wave

drips-wave Bot commented Apr 24, 2026

Copy link
Copy Markdown

@MerlinTheWhiz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

kindly resolve conflict

- Add aria-label to all icon-only buttons across 14 component files
- Add aria-expanded to toggle/disclosure buttons
- Add aria-pressed to toggle state buttons (pin)
- Add contextual aria-labels to per-item action buttons (pause/resume/cancel downloads)
- Fixes: notifications, offline, video, dashboard, messaging, search components

Closes accessibility audit: icon buttons missing ARIA labels
@MerlinTheWhiz
MerlinTheWhiz force-pushed the fix/missing-keyboard-navigation branch from ca1e657 to f65bd55 Compare April 25, 2026 10:02
@MerlinTheWhiz

Copy link
Copy Markdown
Contributor Author

@RUKAYAT-CODER conflicts has been resolved

@RUKAYAT-CODER
RUKAYAT-CODER merged commit 04a4006 into rinafcode:main Apr 25, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Keyboard Navigation

2 participants