feat(governance): add approval requirements policy - #1617
Merged
RUKAYAT-CODER merged 2 commits intoSep 27, 2026
Merged
RUKAYAT-CODER merged 2 commits into
RUKAYAT-CODER merged 2 commits into
Conversation
|
@olakunleakinyele4-max Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds the missing Approval Requirements Policy to the
Governance/folder. The new document defines the minimum number of approvals required per change type, the checks that must pass alongside them, and the narrow override rules, closing the governance gap the issue describes. A companion regression test pins the document's guarantees so they cannot silently regress.Related Issue
Closes #1517
Changes
[ADD]
Governance/policies/APPROVAL_REQUIREMENTS.mdtype-check,lint,build,test) on both the approved and head commits, plus companion governance tests and gap disclosure.[ADD]
Governance/policies/APPROVAL_REQUIREMENTS.test.tsREVIEW_POLICY.test.tsharness (vitest +readFileSync) to assert the document's sections, per-type approval floors, required checks, and override guarantees.Verification Results
APPROVAL_REQUIREMENTS.mddocuments minimum approvals per change type, required checks, and override rulesGovernance/policies/REVIEW_POLICY.test.ts; assertions verified offline (21/21)Closes #1517