fix: guard date-formatting utilities against invalid input - #1327
Merged
RUKAYAT-CODER merged 1 commit intoSep 6, 2026
Merged
Conversation
- Add isValidDate() helper to detect unparseable dates - Add fallback parameter to formatDate, formatShortDate, formatTime, and formatRelative - Return empty string (or custom fallback) when input is invalid instead of throwing RangeError - Add comprehensive unit tests for all date formatting functions Closes rinafcode#1292
|
@CollinsKRO Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds invalid-date guards to the date-formatting utilities in
src/utils/dateUtils.tsto preventRangeError: Invalid time valuewhen unparseable strings/numbers are passed as input.Changes
isValidDate()helper that checks whether a value produces a validDateobjectfallbackparameter toformatDate,formatShortDate,formatTime, andformatRelative— all return an empty string (or a custom placeholder) when the input is invalid instead of throwingsrc/utils/__tests__/dateUtils.test.ts) covering valid dates, invalid strings, empty strings, and custom fallbacksTesting
Related
closes #1292