Skip to content

Comment cleanup and create Skill.md for agents#1146

Merged
LEOYoon-Tsaw merged 1 commit into
rime:masterfrom
LEOYoon-Tsaw:AgenticSkills
Jun 22, 2026
Merged

Comment cleanup and create Skill.md for agents#1146
LEOYoon-Tsaw merged 1 commit into
rime:masterfrom
LEOYoon-Tsaw:AgenticSkills

Conversation

@LEOYoon-Tsaw

@LEOYoon-Tsaw LEOYoon-Tsaw commented Jun 22, 2026

Copy link
Copy Markdown
Member

The project is developed over years, with comments left by numerous contributors in various styles. Here I focus on cleaning up comments that are on already self-explanetary code, and make unnecessarily long comments more concise.

Also added a SKILL.md to guide agentic models on code structure, event cycle and life cycle, as well as coding/comment style to follow. As more and more people using agents to write code, a guidance is increasingly needed for consistent and efficient AI contributions.

@LEOYoon-Tsaw LEOYoon-Tsaw requested a review from lotem June 22, 2026 03:23

@lotem lotem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

善哉

@LEOYoon-Tsaw LEOYoon-Tsaw merged commit 6e2df01 into rime:master Jun 22, 2026
1 check passed
@LEOYoon-Tsaw LEOYoon-Tsaw deleted the AgenticSkills branch June 22, 2026 03:57
@yimmy23

yimmy23 commented Jun 26, 2026

Copy link
Copy Markdown

So good

chenqi2013 added a commit to RWKV-APP/squirrel that referenced this pull request Jul 6, 2026
* 'master' of github.com:RWKV-APP/squirrel: (34 commits)
  fix(installer): declare host architectures
  Comment cleanup and create Skill.md for agents (rime#1146)
  feat: ReservedProperty protocol for plugin→frontend coordination (rime#1143)
  build(xcode): bundle octagram data
  build: update action-build.sh
  Lint
  Localize installer conclusion tip
  Finalize stranded composition when input source is switched away programmatically (rime#1140) (rime#1142)
  build(xcode): generate UUID for new resource files
  update submodules librime=1.17.0, plum
  build: fix warning
  Adopts glass effect on macOS 26+ (rime#1141)
  add report_bundleid to allow App Bundle ID to be accessible from librime
  chore: add user guide for the install package (rime#1133)
  feat(Squirrel cli): add --ascii --nascii --getascii (rime#1070)
  切換應用窗口時更新圖標狀態
  feat(ui): status bar icon reflects ascii_mode (rime#1122)
  feat(ui): 全屏時隨文字縮放動態調整行的長度
  feat(ui): 全屏模式
  fix(ui): 修復邊界重定位導致的背景錯位及超大字號排版截斷問題
  ...

# Conflicts:
#	Assets.xcassets/AppIcon.appiconset/Contents.json
#	Squirrel.xcodeproj/project.pbxproj
#	sources/Main.swift
#	sources/SquirrelInputController.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants