Add vgpu mode for non-MIG NVIDIA vGPU devices - #30
Conversation
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe change documents supported GPU validation modes and updates setup and VM image tasks. ChangesGPU validation mode handling
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@gpu-validation/tasks/setup.yaml`:
- Line 15: Restore the RHEL distribution guard on the RPM-specific dependency
block in setup.yaml while retaining the expanded gpu_validation_mode check for
“mig” and “vgpu”. Ensure the yum_repository and dnf tasks run only on RHEL
hosts, or reject those modes before reaching this block.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Enterprise
Run ID: bb3a689a-63e5-4676-97dc-8f30d489d289
📒 Files selected for processing (3)
gpu-validation/defaults/main.yamlgpu-validation/tasks/setup.yamlgpu-validation/tasks/vm_image.yaml
09c1e7e to
5c0eeb6
Compare
|
Checked the MIG references: https://github.com/search?q=repo%3Arhos-vaf%2Fgpu-validation+MIG&type=code. |
Hi @rlandy. Yes, except the validations specific to MIG. Non-MIG vGPUs need the EPEL repository and DKMS package as dependencies to use the NVIDIA guest grid driver. Removing |
Previously gpu_validation_mode only supported "pci_passthrough" and "mig". New "vgpu" mode shares vGPU scheduling logic with MIG (resources:VGPU=1 flavor extra_specs, GRID guest driver dependencies) but skips MIG-specific checks (nvidia-smi MIG query, MIG enabled assertions). Also fix extra_specs ordering: reset for vGPU/MIG now runs before hugepage merge so hugepages work correctly with all modes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5c0eeb6 to
3876c19
Compare
What does this PR do?
Add vgpu mode for non-MIG NVIDIA vGPU devices:
Why do we need this PR?
Previously
gpu_validation_modeonly supportedpci_passthroughandmig. Newvgpumode shares vGPU scheduling logic with MIG (resources:VGPU=1flavorextra_specs, GRID guest driver dependencies) but skips MIG-specific checks (nvidia-smi MIG query, MIG enabled assertions).Also fix
extra_specsordering: reset for vGPU/MIG now runs before hugepage merge, so hugepages work correctly with all modes.Related: OSPRH-33548