[release-2.6] Add configurable StartupProbe and LivenessProbe to Module CR

[TomerNewman]

Add optional StartupProbe and LivenessProbe fields to CommonContainerSpec, allowing operators to customize probe timing for DevicePlugin containers. When nil, falls back to current defaults.

---

/cc @yevgeny-shnaidman @ybettan

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomerNewman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [TomerNewman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 219333ca-b75e-41c4-8e11-34f5392f313d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[yevgeny-shnaidman]

/lgtm

[TomerNewman]

/override ci/prow/security
failed on a test file

[openshift-ci]

@TomerNewman: Overrode contexts on behalf of TomerNewman: ci/prow/security

Details

In response to this:

/override ci/prow/security
failed on a test file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[TomerNewman]

/retest

[TomerNewman]

/retest

[TomerNewman]

/retest

[TomerNewman]

/retest

[TomerNewman]

/override ci/prow/security

[openshift-ci]

@TomerNewman: Overrode contexts on behalf of TomerNewman: ci/prow/security

Details

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[TomerNewman]

/retest

[TomerNewman]

/cherry-pick release-2.5

[openshift-cherrypick-robot]

@TomerNewman: #1889 failed to apply on top of branch "release-2.5":

Applying: Add configurable StartupProbe and LivenessProbe to Module CR
Using index info to reconstruct a base tree...
M	api/v1beta1/module_types.go
M	api/v1beta1/zz_generated.deepcopy.go
M	bundle-hub/manifests/hub.kmm.sigs.x-k8s.io_managedclustermodules.yaml
M	bundle/manifests/kmm.sigs.x-k8s.io_modules.yaml
M	config/crd-hub/bases/hub.kmm.sigs.x-k8s.io_managedclustermodules.yaml
M	config/crd-hub/bases/kmm.sigs.x-k8s.io_modules.yaml
M	config/crd/bases/kmm.sigs.x-k8s.io_modules.yaml
M	internal/controllers/device_plugin_reconciler.go
M	internal/controllers/device_plugin_reconciler_test.go
M	internal/webhook/module.go
Falling back to patching base and 3-way merge...
Auto-merging api/v1beta1/module_types.go
Auto-merging api/v1beta1/zz_generated.deepcopy.go
Auto-merging bundle-hub/manifests/hub.kmm.sigs.x-k8s.io_managedclustermodules.yaml
Auto-merging bundle/manifests/kmm.sigs.x-k8s.io_modules.yaml
Auto-merging config/crd-hub/bases/hub.kmm.sigs.x-k8s.io_managedclustermodules.yaml
Auto-merging config/crd-hub/bases/kmm.sigs.x-k8s.io_modules.yaml
Auto-merging config/crd/bases/kmm.sigs.x-k8s.io_modules.yaml
Auto-merging internal/controllers/device_plugin_reconciler.go
CONFLICT (content): Merge conflict in internal/controllers/device_plugin_reconciler.go
Auto-merging internal/controllers/device_plugin_reconciler_test.go
Auto-merging internal/webhook/module.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add configurable StartupProbe and LivenessProbe to Module CR

Details

In response to this:

/cherry-pick release-2.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.