Skip to content

EPMRPP-113919 || Track test framework version#259

Merged
maria-hambardzumian merged 2 commits intodevelopfrom
feature/EPMRPP-113919-Track-test-framework-version
Apr 10, 2026
Merged

EPMRPP-113919 || Track test framework version#259
maria-hambardzumian merged 2 commits intodevelopfrom
feature/EPMRPP-113919-Track-test-framework-version

Conversation

@maria-hambardzumian
Copy link
Copy Markdown
Contributor

@maria-hambardzumian maria-hambardzumian commented Apr 9, 2026

Summary by CodeRabbit

  • New Features
    • Added support for optional framework_version parameter in agent information configuration, enabling better tracking of framework details when initializing the ReportPortal client.

@maria-hambardzumian
Copy link
Copy Markdown
Contributor Author

maria-hambardzumian commented Apr 9, 2026

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

Warning

Rate limit exceeded

@maria-hambardzumian has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 7 minutes and 29 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 7 minutes and 29 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1e738dad-eaa4-4274-931d-f27d09e25aae

📥 Commits

Reviewing files that changed from the base of the PR and between 1c6f4c7 and f1860f7.

📒 Files selected for processing (1)
  • statistics/statistics.js

Walkthrough

Added optional framework_version field support to the agent information parameter. The type definition is updated to accept this field, and the statistics module conditionally includes it in event parameters when present.

Changes

Cohort / File(s) Summary
Type Definition
index.d.ts
Updated ReportPortalClient constructor to allow optional framework_version field within agentInfo parameter object.
Statistics Module
statistics/statistics.js
Added conditional logic in getEventParams to include framework_version from agent parameters into the event params object when present.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A new field hops into view,
Framework versions, fresh and true,
Parameters dance in harmony's light,
Agent info shines ever bright! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: adding support for tracking test framework version through a new framework_version field in both the type definition and statistics handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/EPMRPP-113919-Track-test-framework-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
statistics/statistics.js (1)

27-29: Add a regression test for framework_version param mapping.

This new mapping path should be covered in __tests__/statistics.spec.js (the current validation snippet covers agent_name/agent_version only), so future refactors don’t silently drop framework_version.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@statistics/statistics.js` around lines 27 - 29, Add a regression test in
__tests__/statistics.spec.js that verifies the new mapping of framework_version
from agentParams into params: construct a test case that supplies agentParams
containing framework_version (and ensures hasOption(agentParams,
'framework_version') would be true), call the function/path that runs the
snippet (the code that receives agentParams and populates params), and assert
that params.framework_version equals the input value; include this alongside the
existing agent_name/agent_version tests to prevent future regressions.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@statistics/statistics.js`:
- Line 27: Prettier is flagging the inline if-condition; change the single-line
condition `if (agentParams && hasOption(agentParams, 'framework_version') &&
agentParams.framework_version)` to the multiline form so it conforms to
formatting rules—break the condition across multiple lines (one check per line)
inside the `if` header and keep the existing body unchanged; update the `if`
that references `agentParams`, `hasOption`, and `'framework_version'`
accordingly to satisfy Prettier/CI.

---

Nitpick comments:
In `@statistics/statistics.js`:
- Around line 27-29: Add a regression test in __tests__/statistics.spec.js that
verifies the new mapping of framework_version from agentParams into params:
construct a test case that supplies agentParams containing framework_version
(and ensures hasOption(agentParams, 'framework_version') would be true), call
the function/path that runs the snippet (the code that receives agentParams and
populates params), and assert that params.framework_version equals the input
value; include this alongside the existing agent_name/agent_version tests to
prevent future regressions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 81a8b314-8c9e-4afb-bf4b-fe3daf4fe563

📥 Commits

Reviewing files that changed from the base of the PR and between b803003 and 1c6f4c7.

📒 Files selected for processing (2)
  • index.d.ts
  • statistics/statistics.js

Comment thread statistics/statistics.js Outdated
@maria-hambardzumian maria-hambardzumian merged commit 2f6da92 into develop Apr 10, 2026
8 checks passed
@maria-hambardzumian maria-hambardzumian deleted the feature/EPMRPP-113919-Track-test-framework-version branch April 10, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants