feat: run GHA build job locally with act by lmilbaum · Pull Request #23959 · renovatebot/renovate

lmilbaum · 2023-08-20T06:29:56Z

Changes

Context

Documentation (please check one with an [x])

I have updated the documentation, or
No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

Code inspection only, or
Newly added/modified unit tests, or
No unit tests but ran on a real repository, or
Both unit tests + ran on a real repository

rarkins · 2023-08-21T07:03:18Z

I usually use Makefiles although left it out of this project due to the number of Windows users. We face this challenge:

If we put anything in the Makefile which can't be done otherwise, we might accidentally have a project which is hostile to Windows contributors
If everything in the Makefile maps to pnpm ... then we are adding this file just to save 5 characters for each command

So @lmilbaum is there any strong benefit from this?

lmilbaum · 2023-08-21T17:39:58Z

@rarkins Thank you for your feedback. I'm testing something with the PR. It is in draft. Can we review its value or/and alternative options in a later stage?

viceice · 2023-08-25T19:51:43Z

why this is required?

Setup node uses pnpm but the corepack is not enabled yet so the binary is missing.

then enable corepack instead

It is installed with the node setup

sure, but corepack is also available if nodejs is already available

Do we want to merge this before then? That PR is conflicted and waiting for someone to resume it and then hopefully the maintainers to merge it

I do think it has value in merging it. Waiting for a general approval and then I'll rebase.

We'll need a regex manager added to keep it updated though. It's already out of date :)

I would prefer to leave the corepack enable when not on act. maybe we should build our own act image to not need the huge default act image.

lmilbaum · 2023-08-31T03:10:36Z

@viceice ping

rarkins

Add regex manager for updating pnpm version in action

viceice · 2023-09-05T20:29:05Z

This step should not be enabled when running the pipeline with act

viceice · 2023-11-24T08:48:56Z

I would prefer to leave the corepack enable when not on act. maybe we should build our own act image to not need the huge default act image.

viceice · 2023-11-24T08:49:26Z


+    - name: Enable corepack
+      shell: bash
+      run: corepack enable


this will probably not work when there is a pnpm in place

viceice · 2023-11-24T08:49:59Z

+## Run GitHub Action build job locally with act
+
+1. Install act - [installation instructions](https://github.com/nektos/act#installation)
+1. Run (Pick the Large image)


why do we need the large image?

I don't remember now why the large image is required. I do remember that the smaller image doesn't work.

rarkins · 2024-02-18T14:56:06Z

Can this be moved forward to merging or should it be closed?

lmilbaum · 2024-02-18T15:18:48Z

Can this be moved forward to merging or should it be closed?

Thanks @rarkins for reminding me of this PR. Closing.

lmilbaum marked this pull request as draft August 20, 2023 06:30

lmilbaum force-pushed the build branch 2 times, most recently from dd0602b to 98487fc Compare August 20, 2023 06:31

lmilbaum changed the title ~~Build renovate image with make~~ feat: Build renovate image with make Aug 20, 2023

lmilbaum force-pushed the build branch 2 times, most recently from 6bee32f to c135ef8 Compare August 21, 2023 17:37

lmilbaum force-pushed the build branch 7 times, most recently from 0937501 to d583fb7 Compare August 25, 2023 14:55

lmilbaum changed the title ~~feat: Build renovate image with make~~ feat: run GHA build job locally with act Aug 25, 2023

lmilbaum force-pushed the build branch 3 times, most recently from a2ffb29 to 532dc83 Compare August 25, 2023 15:10

lmilbaum marked this pull request as ready for review August 25, 2023 15:11

lmilbaum force-pushed the build branch from 532dc83 to 6bfeb88 Compare August 25, 2023 17:57

viceice reviewed Aug 25, 2023

View reviewed changes

lmilbaum force-pushed the build branch 2 times, most recently from 4dead74 to 2324171 Compare August 26, 2023 13:47

lmilbaum requested a review from viceice August 30, 2023 18:20

lmilbaum force-pushed the build branch from 2324171 to d46a239 Compare August 30, 2023 18:35

rarkins suggested changes Oct 15, 2023

View reviewed changes

feat: run GHA build job locally with act

519cb71

lmilbaum force-pushed the build branch from d46a239 to 519cb71 Compare October 16, 2023 02:32

viceice reviewed Nov 24, 2023

View reviewed changes

lmilbaum closed this Feb 18, 2024

github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2024

Conversation

lmilbaum commented Aug 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Context

Documentation (please check one with an [x])

How I've tested my work (please select one)

Uh oh!

rarkins commented Aug 21, 2023

Uh oh!

lmilbaum commented Aug 21, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lmilbaum commented Aug 31, 2023

Uh oh!

rarkins left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rarkins commented Feb 18, 2024

Uh oh!

lmilbaum commented Feb 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lmilbaum commented Aug 20, 2023 •

edited

Loading