Conversation
This was referenced Jul 4, 2026
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
2 times, most recently
from
July 4, 2026 14:01
91ddeec to
e4b8318
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
July 4, 2026 14:01
e2ea7ec to
68bd7b4
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
July 4, 2026 14:27
e4b8318 to
a5a8c39
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
2 times, most recently
from
July 4, 2026 15:19
3d05d4f to
70b3170
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
2 times, most recently
from
July 4, 2026 15:34
0f19f3a to
ad551c2
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
2 times, most recently
from
July 4, 2026 16:44
5b3055a to
0edd0e6
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
July 4, 2026 16:44
ad551c2 to
59c273f
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
July 4, 2026 16:50
0edd0e6 to
280c0e8
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
July 4, 2026 16:50
59c273f to
18326a2
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
July 4, 2026 16:54
280c0e8 to
26f5599
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
July 4, 2026 16:54
18326a2 to
4c8d170
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
July 4, 2026 17:02
26f5599 to
8702174
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
2 times, most recently
from
July 4, 2026 17:05
9a3dde3 to
4bc5370
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
2 times, most recently
from
July 4, 2026 17:09
3d807f7 to
9f72d77
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
2 times, most recently
from
July 5, 2026 10:51
caaba82 to
d2a52dc
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
July 5, 2026 10:51
9f72d77 to
c740dbc
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
July 5, 2026 10:58
c740dbc to
a396a5d
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
July 5, 2026 10:58
d2a52dc to
10128c7
Compare
febyeji
marked this pull request as draft
July 5, 2026 15:15
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
July 17, 2026 22:10
a396a5d to
87c427f
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
July 17, 2026 22:12
10128c7 to
be9005c
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
July 17, 2026 23:43
87c427f to
2d46560
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
July 17, 2026 23:44
be9005c to
ee1d5ba
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
August 10, 2026 23:21
2d46560 to
f1c005d
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
August 10, 2026 23:21
ee1d5ba to
31528ff
Compare
tperami
reviewed
Aug 18, 2026
| { if name <> "default_tables" then | ||
| failwith ("unsupported page-table option: " ^ name); | ||
| if value then | ||
| failwith "unsupported page-table option: default_tables = true"; |
Collaborator
There was a problem hiding this comment.
We support true, we don't support false
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
August 20, 2026 00:23
31528ff to
6e8417b
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
2 times, most recently
from
August 20, 2026 01:46
4831e13 to
5f190cb
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
August 20, 2026 01:46
6e8417b to
7826f93
Compare
- Parse aligned virtual declarations in page_table_setup. - Treat explicit mapping levels as alignment requests for VA and PA symbols. - Apply VA alignment before assembly layout and PA alignment during page-table construction. - Cover the level-2 VA/PA shorthand with a VM fixture.
- Parse named s1table/s2table roots with explicit bases. - Keep explicit roots reserved while building page tables. - Cover switching between named roots with a VM smoke test.
- Parse option default_tables = true statements in page_table_setup. - Preserve Isla compatibility while keeping the option as a builder no-op. - Reject default_tables = false and unsupported page-table option names. - Cover accepted and rejected values with parser unit tests.
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
from
August 20, 2026 03:31
5f190cb to
79ee163
Compare
febyeji
force-pushed
the
feature/pgt-dsl-default-tables-option
branch
from
August 20, 2026 03:31
7826f93 to
05e0888
Compare
febyeji
force-pushed
the
feature/pgt-dsl-named-tables
branch
2 times, most recently
from
August 20, 2026 07:14
41c4ea0 to
076706d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
option default_tables = truestatements inpage_table_setup.default_tables = falseand unsupported page-table option names during parsing.