Skip to content

feat(onboarding) - add dummy logic to show the preview employment step#1073

Merged
gabrielseco merged 10 commits into
mainfrom
pbyr-3956-ea-preview
Jun 16, 2026
Merged

feat(onboarding) - add dummy logic to show the preview employment step#1073
gabrielseco merged 10 commits into
mainfrom
pbyr-3956-ea-preview

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

I added the new step preview employment step, this a work in progress but its better to merge little PRs instead of creating a big one.

To enable this feature partners need to use the feature flag and I only have enabled the step for Spain in partners...

Vite.+.React.+.TS.-.16.June.2026.mp4

Note

Low Risk
Onboarding changes are gated by feature flag and country availability, and the preview UI is non-functional beyond navigation; risk is mainly from the large generated client export surface if consumers pick up new APIs unintentionally.

Overview
Adds an optional Preview Employment Agreement onboarding step between benefits and review, wired through the flow’s step builder, example app, and PreviewEmploymentAgreementStep (currently a stub that only advances on submit).

Partners enable it with the ea_preview feature plus dynamic_steps. The step is shown only when the selected country’s onboarding country list reports employment_agreement_preview_available (from the regenerated client / Countries API). Country options now carry that flag via useCountriesSchemaField.

The generated src/client bundle is updated in the same PR (employment agreement preview/download, employee bank account, COR termination list, offboardings-by-employment, v2 basic information GET, GP sandbox/state taxes, webhook subscribe_to_all_events, payslip scope docs, etc.); onboarding does not call the preview/download endpoints yet.

Reviewed by Cursor Bugbot for commit 9a3eb9a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

📦 Bundle Size Report

Metric Current Previous Change Status
Total (gzip) 221.62 kB 220.84 kB +787 B (+0.4%) 🔴
Total (raw) 597.29 kB 595.28 kB +2.01 kB (+0.3%) 🔴
CSS (gzip) 20.89 kB 20.89 kB 0 B (0%) 🟢
CSS (raw) 109.09 kB 109.09 kB 0 B (0%) 🟢

Size Limits

  • ✅ Total gzipped: 221.62 kB / 250 kB (88.6%)
  • ✅ Total raw: 597.29 kB / 600 kB (99.5%)
  • ✅ CSS gzipped: 20.89 kB / 25 kB (83.5%)

Largest Files (Top 5)

  1. chunk-Y3CJRZLA.js - 14 kB (0 B (0%))
  2. styles.css - 10.44 kB (0 B (0%))
  3. index.css - 10.44 kB (0 B (0%))
  4. chunk-HQSAZS2Z.js - 6.36 kB (new)
  5. index.js - 6.31 kB (+14 B (+0.2%))
View All Files (339 total)
File Size (gzip) Change
chunk-Y3CJRZLA.js 14 kB 0 B (0%)
styles.css 10.44 kB 0 B (0%)
index.css 10.44 kB 0 B (0%)
chunk-HQSAZS2Z.js 6.36 kB new
index.js 6.31 kB +14 B (+0.2%)
chunk-6VVHACE2.js 6.03 kB new
chunk-G2LZFGZA.js 5.31 kB 0 B (0%)
chunk-OOIH6JX7.js 4.76 kB new
chunk-ZJAXWKHL.js 4.49 kB new
chunk-2NHLKAXU.js 3.89 kB new

✅ Bundle size check passed

@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-nb8046iom-remotecom.vercel.app
Latest Commit:9a3eb9a

Deployed with vercel-action

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-1w88pnp2b-remotecom.vercel.app
Latest Commit:9a3eb9a

Deployed with vercel-action

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Report

⚠️ Coverage decreased

Metric Current Previous Change Status
Lines 88.35% 88.41% -0.06% 🔴
Statements 87.75% 87.81% -0.06% 🔴
Functions 84.77% 84.87% -0.10% 🔴
Branches 79.64% 79.66% -0.02% 🔴

Detailed Breakdown

Lines Coverage
  • Covered: 3813 / 4316
  • Coverage: 88.35%
  • Change: -0.06% (7 lines)
Statements Coverage
  • Covered: 3875 / 4416
  • Coverage: 87.75%
  • Change: -0.06% (7 statements)
Functions Coverage
  • Covered: 1035 / 1221
  • Coverage: 84.77%
  • Change: -0.10% (3 functions)
Branches Coverage
  • Covered: 2378 / 2986
  • Coverage: 79.64%
  • Change: -0.02% (1 branches)

✅ Coverage check passed

@gabrielseco gabrielseco marked this pull request as ready for review June 16, 2026 12:42
@gabrielseco gabrielseco changed the title add preview employment step feat(onboarding) - add dummy logic to show the preview employment step Jun 16, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 5 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a75c201. Configure here.

Comment thread src/flows/Onboarding/hooks.tsx Outdated
Comment thread src/flows/Onboarding/hooks.tsx Outdated
Comment thread src/flows/Onboarding/hooks.tsx
Comment thread src/flows/Onboarding/components/PreviewEmploymentAgreementStep.tsx
Comment thread src/flows/Onboarding/components/PreviewEmploymentAgreementStep.tsx
@gabrielseco gabrielseco self-assigned this Jun 16, 2026
@gabrielseco gabrielseco merged commit 55462d3 into main Jun 16, 2026
11 checks passed
@gabrielseco gabrielseco deleted the pbyr-3956-ea-preview branch June 16, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants