Skip to content

fix: update community social links and X icon - #1799

Open
sb123sb123 wants to merge 1 commit into
reframe-oss:mainfrom
sb123sb123:fix/social-links-1016
Open

sb123sb123 wants to merge 1 commit into
reframe-oss:mainfrom
sb123sb123:fix/social-links-1016

Conversation

@sb123sb123

@sb123sb123 sb123sb123 commented Sep 27, 2026 •

Copy link
Copy Markdown

Closes #1016

Summary

  • Point the footer's X/Twitter and Instagram links to Reframe's accounts.
  • Replace the deprecated Twitter glyph with the X mark and give it an X (Twitter) accessible name.
  • Add a regression test for the destinations, accessible name, and safe new-tab attributes.

Validation

  • bun run lint — passed.
  • bunx tsc --noEmit — passed.
  • bun run build — passed.
  • bun run test -- --run src/components/__tests__/Footer.test.tsx — 1 passed.
  • Desktop and 375px mobile browser checks passed; no browser errors.
  • Full bun run test -- --run — 107 passed, 8 failed in untouched tests: duplicate Vitest imports in src/lib/exportEstimate.test.ts, unavailable localStorage in the existing persistence and theme tests, and an existing useVideoEditor assertion failure.

Screen recording

reframe-footer.webm

@netlify

netlify Bot commented Sep 27, 2026

Copy link
Copy Markdown

👷 Deploy request for reframe-os pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 1eb6230

@github-actions

Copy link
Copy Markdown
Contributor

👋 Thanks for your PR, @sb123sb123!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. ✅ Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions

Copy link
Copy Markdown
Contributor

✅ PR Format Check Passed — @sb123sb123

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:testing Testing labels Sep 27, 2026
@sb123sb123
sb123sb123 marked this pull request as ready for review September 27, 2026 05:09

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:beginner Beginner level - 20 pts type:bug Bug fix type:testing Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Community section social links broken and Twitter logo outdated

1 participant