Skip to content

[feat] Add new pbspro scheduler backend - #3584

Merged
vkarak merged 3 commits into
reframe-hpc:developfrom
colleeneb:develop
Nov 30, 2025
Merged

vkarak merged 3 commits into
reframe-hpc:developfrom
colleeneb:develop

Conversation

@colleeneb

Copy link
Copy Markdown
Contributor

As discussed in detail in #3579, this adds PBSPro as a backend due to differences between PBS and PBSPro.

@codecov

codecov Bot commented Nov 16, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 10.52632% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.19%. Comparing base (2d83a21) to head (e58916a).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
reframe/core/schedulers/pbs.py 10.52% 34 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3584      +/-   ##
===========================================
- Coverage    91.40%   91.19%   -0.22%     
===========================================
  Files           62       62              
  Lines        13584    13622      +38     
===========================================
+ Hits         12417    12423       +6     
- Misses        1167     1199      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vkarak vkarak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, implementation-wise. I pushed some coding style changes + a fix due to a typo. Unfortunately, we cannot unit test it with the current setup that goes through Slurm, so we will have to merge it as-is.

However, we'd need to update the docs.

@github-project-automation github-project-automation Bot moved this from Todo to In Progress in ReFrame Backlog Nov 26, 2025
@colleeneb

Copy link
Copy Markdown
Contributor Author

Thank you for catching the typo and the fixes!

However, we'd need to update the docs.
I can try to update the docs, is there a pointer to what needs to change? I see references for PBS here:

- ``pbs``: Jobs will be launched using the `PBS Pro <https://en.wikipedia.org/wiki/Portable_Batch_System>`__ scheduler.
, is this where to add a reference to pbspro as a scheduler type?

@vkarak

vkarak commented Nov 30, 2025

Copy link
Copy Markdown
Contributor

I can try to update the docs, is there a pointer to what needs to change? I see references for PBS here:

Yes, I fixed this reference from the past and added a line for the new backend.

@vkarak vkarak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now, I updated also the docs.

@vkarak vkarak changed the title [feat] Add PBSPro backend [feat] Add new pbspro scheduler backend Nov 30, 2025
@vkarak
vkarak enabled auto-merge November 30, 2025 13:32
@vkarak
vkarak merged commit df559d5 into reframe-hpc:develop Nov 30, 2025
66 of 71 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in ReFrame Backlog Nov 30, 2025
@colleeneb

Copy link
Copy Markdown
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants