Repository navigation
[feat] Add new pbspro scheduler backend - #3584
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3584 +/- ##
===========================================
- Coverage 91.40% 91.19% -0.22%
===========================================
Files 62 62
Lines 13584 13622 +38
===========================================
+ Hits 12417 12423 +6
- Misses 1167 1199 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vkarak
left a comment
There was a problem hiding this comment.
Lgtm, implementation-wise. I pushed some coding style changes + a fix due to a typo. Unfortunately, we cannot unit test it with the current setup that goes through Slurm, so we will have to merge it as-is.
However, we'd need to update the docs.
|
Thank you for catching the typo and the fixes!
|
Yes, I fixed this reference from the past and added a line for the new backend. |
vkarak
left a comment
There was a problem hiding this comment.
Lgtm now, I updated also the docs.
pbspro scheduler backend
|
Thank you so much! |
As discussed in detail in #3579, this adds PBSPro as a backend due to differences between PBS and PBSPro.