fix(mui): apply MUI styling props to Breadcrumb links#7463
Open
salluexez wants to merge 2 commits into
Open
Conversation
- Replace <span> with MuiLink component in LinkRouter - Ensures sx, underline, color, variant props actually style the links - Fixes flex alignment, hover underline, color inheritance, and typography - Resolves regression from v5 migration (refinedev#6945) Fixes refinedev#7462
🦋 Changeset detectedLatest commit: b8e6fc8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull request overview
Fixes a regression in @refinedev/mui Breadcrumb rendering where MUI LinkProps styling props (sx, underline, color, variant) were being forwarded onto a plain DOM <span> (producing invalid/inert HTML attributes) instead of being applied via an MUI component.
Changes:
- Updated
LinkRouterto render a<MuiLink component="span">inside the router<Link>, so MUI styling props are handled by MUI rather than the DOM. - Restores expected breadcrumb link styling behavior (typography variant, underline-on-hover, color inheritance, flex alignment).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a regression in the Breadcrumb component where MUI styling props
(
sx,underline,color,variant) were being rendered as invalidHTML attributes on a bare
<span>instead of being applied to an actualMUI Link component.
Changes
LinkRouterto wrap content in<MuiLink component="span">instead of a plain
<span>Impact
Testing
Closes #7462