fix(core): preserve falsy values in getDefaultFilter#7451
Open
devteamaegis wants to merge 1 commit into
Open
Conversation
getDefaultFilter used `filter.value || []`, replacing valid falsy filter values (0, false, "") with an empty array. Default values for numeric/boolean/empty-string filters were lost when populating form controls. Use `filter.value ?? []` so only undefined/null fall back.
🦋 Changeset detectedLatest commit: 24ff9ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
getDefaultFilterreturnsfilter.value || [], so a valid filter value of0,false, or""is silently replaced with[]. It's used to seed form controls from active filters, so filtering on e.g.status = 0or a boolean loses the real default and the control comes up empty.Why it happens
|| []treats every falsy value as "missing". The[]fallback is only meant for an absent value (the existing empty-array test usesvalue: undefined).Fix
Use nullish coalescing (
?? []) so onlyundefined/nullfall back to[].Test
Added a case asserting
0,false, and""round-trip throughgetDefaultFilter; the existingundefined → []behaviour is unchanged.