Skip to content

[release-2.1] chore(rhdh): pin image and catalog index tag to 2.1 - #565

Merged
rm3l merged 7 commits into
release-2.1from
chore/switch-to-next-2.1-rhdh-tag
Sep 30, 2026
Merged

rm3l merged 7 commits into
release-2.1from
chore/switch-to-next-2.1-rhdh-tag

Conversation

@rm3l

@rm3l rm3l commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Description of the change

Pins the RHDH image and catalog index image to 2.1 in the release-2.1 branch for stability.

Existing or Associated Issue(s)

Additional Information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@rm3l

rm3l commented Sep 29, 2026

Copy link
Copy Markdown
Member Author

/bump rhdh patch

Signed-off-by: RHDH Bot <146280956+rhdh-bot@users.noreply.github.com>
@rm3l rm3l changed the title [release-2.1] chore(rhdh): Update image tag in values.yaml to 'next-2.1' [release-2.1] chore(rhdh): pin image and catalog index tag to next-2.1 and 2.1 Sep 29, 2026
@rm3l
rm3l marked this pull request as ready for review September 29, 2026 09:07
@rm3l
rm3l requested a review from a team as a code owner September 29, 2026 09:07
@rm3l rm3l changed the title [release-2.1] chore(rhdh): pin image and catalog index tag to next-2.1 and 2.1 [release-2.1] chore(rhdh): pin image and catalog index tag to 2.1 Sep 29, 2026
@rhdh-qodo-merge

Copy link
Copy Markdown

PR Summary by Qodo

Set RHDH 2.1 image defaults and bump chart to 3.4.2

⚙️ Configuration changes 📝 Documentation 🕐 10-20 Minutes

Grey Divider

AI Description

• Set the RHDH image default to next-2.1 and catalog index default to 2.1 for the release-2.1
 branch.
• Bump the chart to 3.4.2 and align its schema and README with the new defaults.
Diagram

graph TD
  V["Chart defaults"] --> H["Image helper"] --> P["Pod template"] --> C["RHDH containers"]
  P --> E["Catalog index env"]
  V --> D["Schema and README"]
Loading
High-Level Assessment

The following are alternative approaches to this PR:

1. Pin image digests
  • ➕ Provides immutable, reproducible image selections even if tags move.
  • ➖ Requires an explicit update for every desired image revision and does not follow the 2.1 tag automatically.

Recommendation: Use the proposed tags if the release branch should continue receiving images published to its 2.1 channels. If stability means identical images across installs, pin both image digests instead; the proposed tags alone do not guarantee that.

Files changed (4) +9 / -9

Documentation (1) +4 / -4
README.mdDocument chart 3.4.2 and the 2.1 image defaults +4/-4

Document chart 3.4.2 and the 2.1 image defaults

• Updates the version badge and install example. The values table now shows 'next-2.1' for the RHDH image and '2.1' for the catalog index.

charts/rhdh/README.md

Other (3) +5 / -5
Chart.yamlBump RHDH chart version to 3.4.2 +1/-1

Bump RHDH chart version to 3.4.2

• Changes the chart version from 3.4.1 to 3.4.2 while leaving appVersion at 2.1.0.

charts/rhdh/Chart.yaml

values.schema.jsonAlign schema defaults with the new image tags +2/-2

Align schema defaults with the new image tags

• Changes the declared default tags for the RHDH image and catalog index to 'next-2.1' and '2.1', respectively.

charts/rhdh/values.schema.json

values.yamlSet release-2.1 image tag defaults +2/-2

Set release-2.1 image tag defaults

• Changes the default RHDH image tag from 'next' to 'next-2.1' and the catalog index tag from 'next' to '2.1'.

charts/rhdh/values.yaml

@rhdh-qodo-merge

rhdh-qodo-merge Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (1) 📘 Rule violations (0) 🔗 Cross-repo conflicts (0) 📜 Skill insights (0)

Grey Divider


Remediation recommended

1. Future generation restores the old image tags 🐞 Bug ⚙ Maintainability
Description
The chart defaults now use next-2.1 and 2.1, but the README template and schema template still
declare next for these images. Regenerating those artifacts can reintroduce stale user-facing
documentation and schema defaults that disagree with the deployed chart.
Code

charts/rhdh/values.yaml[34]

+  tag: "next-2.1"
Relevance

●●● Strong

Recent precedents accept synchronizing generated documentation and source templates after default
changes to prevent regeneration drift.

PR-#542
PR-#533

ⓘ Recommendations generated based on similar findings in past PRs

Evidence
The changed values establish next-2.1 for the application image and 2.1 for the catalog index,
while the README template still documents the old application tag and the schema template still
defines next for both defaults. The checked-in generated README table and schema have already been
partially updated, proving the source templates are now inconsistent with their generated artifacts
and can cause future regeneration drift.

charts/rhdh/values.yaml[31-35]
charts/rhdh/README.md.gotmpl[192-196]
charts/rhdh/values.schema.tmpl.json[57-60]
charts/rhdh/values.schema.tmpl.json[827-831]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The chart defaults were changed to `next-2.1` and `2.1`, but the README and JSON schema source templates still use `next`. Future generation can overwrite or expose stale defaults.

## Fix Focus Areas
- charts/rhdh/README.md.gotmpl[192-196]
- charts/rhdh/values.schema.tmpl.json[57-60]
- charts/rhdh/values.schema.tmpl.json[827-831]

## Recommended Fix
Update the README example to use `quay.io/rhdh-community/rhdh:next-2.1`, update the application image schema template default to `next-2.1`, and update the catalog index schema template default to `2.1`. Regenerate the derived README and schema artifacts and verify all defaults match `values.yaml`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

Dismiss ↗ | View ↗


Grey Divider

Context sources
✅ Cross-repo context — repo relationships
  Explored: repo: redhat-developer/rhdh (branch: release-2.1, sha: 16f492ab) — View relationship
Review mode: 🚀 Fast: This is a localized, low-risk Helm values and metadata pin change with no new logic or high-risk behavior.

Grey Divider

Tip of the day
💡 Did you know, you can route each severity your way: inline, summary, both, or drop

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@rhdh-qodo-merge

Copy link
Copy Markdown

Important

The /generate_labels command by Qodo is sunsetting on the 1st of October 2026 and will no longer be available. We recommend switching to the latest Qodo review capabilities. Learn more

@rm3l

rm3l commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

/bump rhdh patch

rhdh-bot and others added 2 commits September 30, 2026 06:40
Signed-off-by: RHDH Bot <146280956+rhdh-bot@users.noreply.github.com>
@rm3l

rm3l commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

/bump rhdh patch

Signed-off-by: RHDH Bot <146280956+rhdh-bot@users.noreply.github.com>
@sonarqubecloud

Copy link
Copy Markdown

@rm3l

rm3l commented Sep 30, 2026

Copy link
Copy Markdown
Member Author

Merging to align with redhat-developer/rhdh-operator#3643

@rm3l
rm3l merged commit 46636dc into release-2.1 Sep 30, 2026
7 of 8 checks passed
@rm3l
rm3l deleted the chore/switch-to-next-2.1-rhdh-tag branch September 30, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants