Repository navigation
Run the release job in the protected release environment - #139
Merged
Merged
Conversation
The release environment only accepts deployments from v* tags. Moving the DOCKERHUB_* secrets into it means branch and PR workflows cannot read the registry credentials. Clears zizmor's secrets-outside-env findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #138. This clears the two
secrets-outside-envfindings (medium) that were left open there.Change
The release job now runs in a
releaseenvironment, which I've created. Its deployment policy allows onlyv*tags. Once the Docker Hub secrets move into it, no branch or PR workflow can read them, even if a workflow file is edited to try.Rollout order (safe at every step)
DOCKERHUB_*secrets, so nothing breaks in between.DOCKERHUB_USERNAMEandDOCKERHUB_TOKENasreleaseenvironment secrets.Verification
actionlint: cleanzizmor --persona=auditor: 0 high, 0 medium, 0 low. Only the 3 informational unnamed-job findings remain.v*tag. A tag ref matches the environment policy, and so does a manual dispatch with--ref v1.0.x.