feat: expose interaction phase for UI feedback#7
Merged
Conversation
The deck already exposes progress and direction as UI-thread interaction values. App-level feedback needs a stable lifecycle signal that does not depend on JS event timing. This adds an additive phase shared value for idle, dragging, dismissing, and undoing. Committed model events remain separate from frame-synchronous visual feedback. Constraint: Limit this PR to interaction.phase only. Constraint: Do not add committedDirection, progress splitting, or worklet callbacks. Constraint: Preserve existing gesture and animation behavior. Rejected: useDeckEvent phase event | phase is UI-thread feedback, not a committed JS event Rejected: Thin phase setter helper | direct shared-value writes are clearer for now Confidence: high Scope-risk: moderate Directive: Do not bridge phase to React state without a separate JS observer API Tested: yarn format:check; yarn lint; yarn typecheck --pretty false Tested: yarn tsc -p example/tsconfig.json --noEmit --pretty false Tested: yarn jest --runInBand; yarn build Not-tested: Manual device visual verification after the final example chip tweak
🦋 Changeset detectedLatest commit: 167575d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Interaction phase is a public API addition. The release bump should be minor rather than patch. Constraint: Preserve the original feature commit. Confidence: high Scope-risk: narrow Tested: yarn format:check Not-tested: Full test suite; changeset metadata only
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.