Skip to content

fix: remove tabIndex={-1} from clear button to make it keyboard accessible #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyphercodes wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −39
Open

fix: remove tabIndex={-1} from clear button to make it keyboard accessible #168

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8edef9
fix: remove tabIndex={-1} from clear button to make it keyboard acces…
cyphercodes Mar 25, 2026
8a88023
test: update clear button accessibility expectations
cyphercodes Apr 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/BaseInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ const BaseInput = React.forwardRef<HolderRef, BaseInputProps>((props, ref) => {
clearIcon = (
<button
type="button"
tabIndex={-1}
onClick={(event) => {
handleReset?.(event);
onClear?.();
Expand Down
Loading