Repository navigation
fix(ci): run changeset version via a yarn script so the manifest sync executes - #4064
Open
razorpay-slash[bot] wants to merge 1 commit into
Open
razorpay-slash[bot] wants to merge 1 commit into
razorpay-slash[bot] wants to merge 1 commit into
Conversation
changesets/action@v1 runs the `version` input through @actions/exec without a shell, so the `&&` in `yarn changeset version && node scripts/syncPluginManifestVersion.js` was passed to the changesets CLI as a literal argument. The CLI failed with "Too many arguments passed to changesets", no version bump was produced, changeset-release/master ended up identical to master, and the release PR creation failed with "No commits between master and changeset-release/master". Move the compound command into a package.json script (matching the existing `publish: yarn release` pattern) and reference it from the workflow.
razorpay-slash
Bot
added
the
Auto-Created PR
|
Collaborator
🛡️ Coverage ReportSummaryFull Coverage Details |
![razorpay-slash[bot]](https://avatars.githubusercontent.com/in/4548214?s=60&v=4){kind=small}
Author
There was a problem hiding this comment.
✨ Agentic PR Review ✨
Status: Approved ✅
Verdict: No major or critical issues found. This is a CI/config-only change ( .github/workflows/release.yml + package.json) with no component or UI surface, so there is nothing to verify in Storybook. No inline comments.
Note: posted as a review comment — the automation identity used here cannot submit an approving review. The skill's post-review.js also could not run because gh api writes are read-only in this environment.
rzpcibot
added
the
✨ Agentic Merge Ready ✨
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Blade Releaseworkflow has been failing on every push tomasterat the "Create Release Pull Request & Publish packages" step:Run: https://github.com/razorpay/blade/actions/runs/38861355573
Root cause
changesets/action@v1executes theversioninput with@actions/execwithout a shell:The
versioninput was a compound shell command:Because there is no shell,
&&was passed to the changesets CLI as a literal argument, producingchangeset version '&&' node scripts/syncPluginManifestVersion.js. The CLI errored with "Too many arguments", no version bump was written,changeset-release/masterwas pushed identical tomaster, and the action then failed to open the release PR ("No commits between master and changeset-release/master").This was introduced in #4040, which added the
versioninput.Fix
Move the compound command into a
package.jsonscript — the same pattern the workflow already uses forpublish: yarn release— and call it from the workflow:yarn <script>runs the script through a shell, so&&is interpreted andsyncPluginManifestVersion.jsruns afterchangeset versionas intended.Verification
Not infra-related: the failure is a deterministic command-parsing bug in the workflow config, and it reproduces on every master push while pending changesets exist.