✨ feat: implement allSettled()#1
Open
rauhryan wants to merge 5 commits into
Open
Conversation
…tside#1157) The @effectionx/inline package exports a ./swc entry pointing to a WASM binary build artifact. This file doesn't exist in git clones and isn't parseable as TypeScript, causing the website build to crash with a readTextFile ENOENT error.
The www workflow was running `deno task dev`, which wraps the server in @effectionx/watch. That watcher restarts the server when files change in the working directory — including `www/built/`, where Staticalize writes crawled pages. A restart mid-crawl returned 500 to in-flight requests, causing intermittent failures on a different URL each run. Run the server directly in CI; no watcher needed.
rauhryan
force-pushed
the
rr/all-settled-898
branch
2 times, most recently
from
d1f564c to
98c30ba
Compare
* ✨ expose Result<T> as public API * 🐛 wrap non-Error causes passed to Err() * ♻️ tweak up, including doc fixes --------- Co-authored-by: Charles Lowell <cowboyd@frontside.com>
rauhryan
force-pushed
the
rr/all-settled-898-impl
branch
from
68b7a87 to
612a383
Compare
rauhryan
force-pushed
the
rr/all-settled-898-impl
branch
from
612a383 to
898f73e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Addresses thefrontside#898 by adding an Effection analogue to
Promise.allSettled().This PR is stacked on top of upstream PR thefrontside#1149, which makes
Result<T>part of the documented public API.Approach
allSettled()as a new combinator built fromall()overbox()-wrapped operationsResult<T>values instead of promise-stylefulfilled/rejectedrecordsallSettled()from the public module surfaceallSettled()semantics