Repository navigation
Update cugraph_etl to create columns and data in the specified data type - #5694
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
KyleFromNVIDIA
left a comment
KyleFromNVIDIA
left a comment
There was a problem hiding this comment.
CMake looks good. Left a few comments on the CI scripts and the implementation. I don't know enough to comment on the test.
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
Co-authored-by: Kyle Edwards <kyedwards@nvidia.com>
| rapids_test_install_relocatable( | ||
| INSTALL_COMPONENT_SET testing | ||
| DESTINATION bin/gtests/libcugraph_etl | ||
| ) |
There was a problem hiding this comment.
With this, we need to update the test Conda package to depend on libcugraph_etl (or split the etl tests into their own package).
There was a problem hiding this comment.
libcugraph_etl gets build (and installed) with libcugraph, not separately. So I expected this would simply add the libcugraph_etl subdirectory into the libcugraph artifacts.
There was a problem hiding this comment.
But I guess we need to change the linkage somehow since it's failing.
|
/merge |
4 participants
Also adds C++ unit tests to validate that the types are correct.
Closes #5692