Skip to content

fix Alice/bob signed context for clear3() #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rouzwelt merged 9 commits into from
Aug 8, 2026
Merged

fix Alice/bob signed context for clear3() #458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
aab2336
init
rouzwelt Jul 7, 2026
03716af
Update flake.nix
rouzwelt Jul 16, 2026
82cdc2a
Merge branch 'master' into 2026-07-07-fix-clear-signed-context
rouzwelt Jul 20, 2026
5d5be8b
Merge branch 'master' into 2026-07-07-fix-clear-signed-context
rouzwelt Jul 20, 2026
aaf45b5
Merge branch 'master' into 2026-07-07-fix-clear-signed-context
rouzwelt Jul 20, 2026
f3e900b
Merge branch 'master' into 2026-07-07-fix-clear-signed-context
rouzwelt Jul 20, 2026
31d788a
Merge branch 'master' into 2026-07-07-fix-clear-signed-context
rouzwelt Jul 20, 2026
307fe9f
Merge branch 'master' into 2026-07-07-fix-clear-signed-context
rouzwelt Jul 26, 2026
031734f
Merge branch 'master' into 2026-07-07-fix-clear-signed-context
rouzwelt Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/modes/intra/simulation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,8 +665,8 @@ describe("Test IntraOrderbookTradeSimulator", () => {
aliceBountyVaultId: simulator.inputBountyVaultId,
bobBountyVaultId: simulator.outputBountyVaultId,
},
simulator.tradeArgs.orderDetails.takeOrder.struct.signedContext,
simulator.tradeArgs.counterpartyOrderDetails.struct.signedContext,
simulator.tradeArgs.orderDetails.takeOrder.struct.signedContext,
],
});
expect(encodeFunctionData).toHaveBeenNthCalledWith(4, {
Expand Down
8 changes: 4 additions & 4 deletions src/core/modes/intra/simulation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,8 +311,8 @@ export class IntraOrderbookTradeSimulator extends TradeSimulatorBase {
aliceBountyVaultId: this.inputBountyVaultId,
bobBountyVaultId: this.outputBountyVaultId,
},
this.tradeArgs.orderDetails.takeOrder.struct.signedContext,
this.tradeArgs.counterpartyOrderDetails.struct.signedContext,
this.tradeArgs.counterpartyOrderDetails.struct.signedContext, // bob's signedContext for alice
this.tradeArgs.orderDetails.takeOrder.struct.signedContext, // alice's signedContext for bob
],
});
return encodeFunctionData({
Expand Down Expand Up @@ -369,8 +369,8 @@ export class IntraOrderbookTradeSimulator extends TradeSimulatorBase {
aliceBountyVaultId: this.inputBountyVaultId,
bobBountyVaultId: this.outputBountyVaultId,
},
this.tradeArgs.orderDetails.takeOrder.struct.signedContext,
this.tradeArgs.counterpartyOrderDetails.struct.signedContext,
this.tradeArgs.counterpartyOrderDetails.struct.signedContext, // bob's signedContext for alice
this.tradeArgs.orderDetails.takeOrder.struct.signedContext, // alice's signedContext for bob
],
});
return encodeFunctionData({
Expand Down
Loading