Skip to content

Deploy DiaWords deterministically via Zoltu#52

Open
Siddharth2207 wants to merge 7 commits into
audit/parse-eval-encoding-contractfrom
audit/deterministic-deployment
Open

Deploy DiaWords deterministically via Zoltu#52
Siddharth2207 wants to merge 7 commits into
audit/parse-eval-encoding-contractfrom
audit/deterministic-deployment

Conversation

@Siddharth2207

@Siddharth2207 Siddharth2207 commented Jul 17, 2026

Copy link
Copy Markdown

Summary

  • replace nonce-dependent new DiaWords() in script/Deploy.sol with Zoltu CREATE2 deployment
  • add LibDiaWordsDeploy pinning expected address and runtime codehash
  • test address derivation, codehash self-consistency, and Zoltu deploy replay

Stack

Stacks on audit/parse-eval-encoding-contract. Formerly #39.

Test plan

  • nix develop -c forge test
  • CI copy-artifacts + rainix-sol

Addresses audit HIGH finding: non-deterministic production deploy path.

Made with Cursor

@coderabbitai

coderabbitai Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: e7c9eabf-96e6-4602-a647-5007d0d9b7d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch audit/deterministic-deployment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Siddharth2207
Siddharth2207 requested a review from JuaniRios July 17, 2026 15:05
This was referenced Jul 17, 2026
Open
Open
Open
Open
Open
Open
@Siddharth2207 Graphite App

Siddharth2207 commented Jul 17, 2026

Copy link
Copy Markdown
Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

JuaniRios
JuaniRios requested changes Jul 17, 2026
View reviewed changes
Comment thread script/Deploy.sol Outdated
Comment thread script/Deploy.sol
Comment thread test/src/lib/deploy/LibDiaWordsDeploy.t.sol
@thedavidmeister thedavidmeister mentioned this pull request Jul 17, 2026
Open
@Siddharth2207
Siddharth2207 force-pushed the audit/parse-eval-encoding-contract branch from f72b4a0 to aa8a314 Compare July 18, 2026 13:45
@Siddharth2207
Siddharth2207 force-pushed the audit/deterministic-deployment branch from d486c1b to 158f686 Compare July 18, 2026 13:45
Siddharth2207 and others added 6 commits July 18, 2026 19:32
@Siddharth2207 @cursoragent
Deploy DiaWords deterministically via Zoltu CREATE2
4d1c0fc 
Replace nonce-dependent `new DiaWords()` in the deploy script with a pinned
Zoltu deployment record and tests that lock address and codehash invariants.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207 @cursoragent
Fix CI: slither too-many-digits and forge fmt on Deploy.sol
235527f 
Keep type(DiaWords).creationCode in script/tests only so slither does not
analyze the embedded bytecode literal in src/lib/deploy.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207 @cursoragent
Update DiaWords Zoltu deployment pins to match current bytecode.
b4938a4 
Restores LibDiaWordsDeploy address and codehash after upstream stack rebases.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207 @cursoragent
Update DiaWords Zoltu pins after full stack rebase.
ee0d598 
Bytecode changed with merged validation and codegen PRs; refresh address and codehash.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207 @cursoragent
Update DiaWords Zoltu pins after review fixes
66ade8c 
Keep the deterministic deployment record aligned with the revised DiaWords bytecode.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207 @cursoragent
Make deterministic deployment safely repeatable
4eccabb 
Reuse verified code at the pinned address and exercise both deployment safety reverts through the production script.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207
Siddharth2207 force-pushed the audit/deterministic-deployment branch from 158f686 to 4eccabb Compare July 18, 2026 14:04
@Siddharth2207
Siddharth2207 force-pushed the audit/parse-eval-encoding-contract branch from aa8a314 to 6652645 Compare July 18, 2026 14:04
@Siddharth2207 @cursoragent
Fix single-contract static check for deploy tests
d12e2c9 
Move the test helper into its own source file so the Rain static convention check accepts the deployment suite.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Siddharth2207
Siddharth2207 requested a review from JuaniRios July 18, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JuaniRios JuaniRios Awaiting requested review from JuaniRios

Assignees

@Siddharth2207 Siddharth2207

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Siddharth2207 @JuaniRios