fix: move skip to global [tool.cibuildwheel] to fix validate-pyprojec… - #1095
Closed
sun-9545sunoj wants to merge 2 commits into
Closed
fix: move skip to global [tool.cibuildwheel] to fix validate-pyprojec…#1095sun-9545sunoj wants to merge 2 commits into
sun-9545sunoj wants to merge 2 commits into
Conversation
…t error
The property is a global-only key in the cibuildwheel JSON schema.
Placing it inside [tool.cibuildwheel.linux] caused validate-pyproject to
reject the file with:
[ERROR] must not contain {'skip'} properties
Moving up to [tool.cibuildwheel] satisfies the
schema validator while keeping identical runtime behaviour — musllinux
build identifiers do not exist on macOS or Windows, so the glob pattern
still only ever matches Linux builds.
Fixes quantumlib#1084
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request moves the skip = "*musllinux*" configuration in pyproject.toml from the Linux-specific [tool.cibuildwheel.linux] section to the global [tool.cibuildwheel] section. There are no review comments, and I have no feedback to provide.
On GitHub Windows runners, running cmake from a plain bash shell has no MSVC Developer Command Prompt environment loaded, so the default NMake generator fails immediately with: CMake Error: Running 'nmake' '-?' failed with: The system cannot find the file specified Fix: - Add microsoft/setup-msbuild before the cmake step (Windows only) to initialize the MSVC environment. - Set CMAKE_GENERATOR=Ninja on Windows. Ninja is pre-installed on all GitHub Windows runners and does not require a Developer Command Prompt the way NMake or Visual Studio generators do.
github-actions
Bot
added
size: S
Contributor
Author
|
closing this pr due to some issues with cla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property is a global-only key in the cibuildwheel JSON schema. Placing it inside [tool.cibuildwheel.linux] caused validate-pyproject to reject the file with:
[ERROR] must not contain {'skip'} properties
Moving up to [tool.cibuildwheel] satisfies the
schema validator while keeping identical runtime behaviour — musllinux build identifiers do not exist on macOS or Windows, so the glob pattern still only ever matches Linux builds.
Fixes #1084