Keep ResultDict unchanged when ResultDict.measurements raises an exception

[pavoljuhas]

Problem: After ResultDict.measurements raises ValueError,
a second call would pass instead of raising ValueError again.

Solution: Avoid mutating ResultDict until the measurements
map is successfully resolved.

[pavoljuhas]

NB: Plugging a corner case found whilst reviewing #8352.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.59%. Comparing base (1403830) to head (125bb7e).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8423   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        1133     1133           
  Lines      103919   103921    +2     
=======================================
+ Hits       103498   103500    +2     
  Misses        421      421           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mhucka]

Noticed a possible deficiency in the test.

[mhucka]

Since the PR description says

After ResultDict.measurements raises ValueError, a second call would pass instead of raising ValueError again

should this test be repeated here? I.e.,

Suggested change

	with pytest.raises(ValueError, match="Cannot extract 2D measurements"):
	_ = r.measurements
	with pytest.raises(ValueError, match="Cannot extract 2D measurements"):
	_ = r.measurements
	# Check that a second access raises ValueError again.
	with pytest.raises(ValueError, match="Cannot extract 2D measurements"):
	_ = r.measurements