Repository navigation
fix(pipedrive): request only the OAuth2 scopes the app uses - #249
Open
nickmazurenko wants to merge 1 commit into
Open
nickmazurenko wants to merge 1 commit into
nickmazurenko wants to merge 1 commit into
Conversation
The Pipedrive app asked for four scopes nothing in it calls: mail:full (no mailbox endpoint is allowed), recents:read (no /recents call), phone-integration (no call logs) and goals:read (no goals). Pipedrive's Marketplace review rejects apps that request scopes their functionality does not use, and users see every scope on the consent page. The list now matches what the catalogue does: base, deals, activities, contacts, products, leads and projects with full access (actions, the record-based operations and the allowed-value lookups), users:read (the user trigger, user lookups and the /users/me ping), search:read (record search) and webhooks:full (the seven triggers register webhooks). The Marketplace app configuration carries the same set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Pipedrive Marketplace submission: the reviewer checks that an app requests only the scopes its functionality uses, and the consent page shows every scope to the user.
Change
oauth2_scopesof the Pipedrive app drops four scopes nothing in the catalogue calls:mail:fullallowed-pathsrecents:read/recentscall anywherephone-integrationgoals:readWhat stays maps to real use:
base;deals:full,activities:full,contacts:full,products:full,leads:full,projects:full(actions, record-based create/update/delete/search, allowed-value lookups, filters);users:read(user trigger, user lookups, the/users/meping);search:read(record search);webhooks:full(the seven triggers register and remove webhooks).The Developer Hub app for the Marketplace is configured with exactly this set, so the two stay in step.
Verification
tsc --noEmitclean;src/tests/pipedrive-migration.test.ts15/15.