Conversation
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
|
I'll leave this open for the rest of day in case others would like to provide feedback. |
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
LG, thank! Just few minor comments.
| minor code changes to adopt. For more information, refer to the | ||
| [documentation](https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-strict-bytes). | ||
|
|
||
| Finally, `--allow-redefinition-new` will be renamed to `--allow-redefinition`. If you want |
There was a problem hiding this comment.
Maybe add a super short motivation/reminder for why --allow-redefinition-new is better. E.g. mention that it supports conditional redefinition?
|
|
||
| Also, we are planning to turn local partial types on by default in mypy 2.0 (to be | ||
| released soon), and this makes the change much less disruptive. However, explicitly | ||
| disabling local partial types will continue to be supported indefinitely. |
There was a problem hiding this comment.
Actually, I am not sure about this. I would propose to deprecate and delete support for non-local partial types at some point. This is because parallel type checking will also require --local-partial-types very soon.
|
|
||
| ### Experimental New Parser | ||
|
|
||
| If you install mypy using `pip install mypy[native-parse]` and run mypy with |
There was a problem hiding this comment.
Not sure why I named the optional dependency native-parse without r at the end. I think we should rename it to native-parser for consistency with the flag name.
3 participants
Add sections for major features and list items for small user-visible changes.
Document expected major changes in the mypy 2.0 release.
This is still not quite final, but should be close to it.
Related issue: #20726