Skip to content

Add command timeout#9

Merged
rosjat merged 2 commits into
python-scsi:masterfrom
jackeichen:master
Jun 13, 2026
Merged

Add command timeout#9
rosjat merged 2 commits into
python-scsi:masterfrom
jackeichen:master

Conversation

@jackeichen

@jackeichen jackeichen commented May 15, 2026

Copy link
Copy Markdown
Contributor

Add command timeout

@jackeichen

jackeichen commented May 15, 2026

Copy link
Copy Markdown
Contributor Author

@rosjat @Flameeyes @sahlberg Hi guys, here is the expected change in the code. Please check and give the feedback.

This PR is related to python-scsi/python-scsi#149.

Use a const value "DEFAULT_TIMEOUT", to help to get the default timeout by:
from sgio import DEFAULT_TIMEOUT

rosjat
rosjat requested changes May 15, 2026
View reviewed changes
Comment thread src/linux_sgio.pyx Outdated
from libc.errno cimport errno
from libc.stdlib cimport calloc, free

DEFAULT_TIMEOUT = 1800000

@rosjat rosjat May 15, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is unessesary, you can simply pass the value in the execute method this is the default if you dont provide a vaklue in the call.

timeout=1800000

@jackeichen jackeichen May 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@jackeichen
Add command timeout
1c395ca 
Add command timeout(2nd)
@jackeichen jackeichen marked this pull request as ready for review May 17, 2026 13:00
@jackeichen jackeichen requested a review from rosjat May 18, 2026 09:39
rosjat
rosjat approved these changes May 23, 2026
View reviewed changes

@rosjat rosjat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rosjat

rosjat commented May 23, 2026

Copy link
Copy Markdown
Contributor

@jackeichen I updated some workflow dependencies for github please pull master and merge it into your feature branch then push the merge commit so the PR gets the correct dependency to run the precommit

@jackeichen

jackeichen commented May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@jackeichen I updated some workflow dependencies for github please pull master and merge it into your feature branch then push the merge commit so the PR gets the correct dependency to run the precommit

@rosjat Another fails:

install pre-commit
Error: getCacheEntry failed: <h2>Our services aren't available right now</h2><p>We're working to restore all services as soon as possible. Please check back soon.</p>0YKkRagAAAADlfuzLC3QQTIzrp3aAehZ6UEhMMzBFREdFMDExMQBFZGdl

@jackeichen jackeichen requested a review from rosjat June 2, 2026 01:43
@rosjat rosjat merged commit 9264eb0 into python-scsi:master Jun 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rosjat rosjat Awaiting requested review from rosjat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackeichen @rosjat