fix: prevent tab anchor from overriding non-tab URL hashes#204
Open
harshitbansal184507 wants to merge 1 commit intopython-poetry:mainfrom
Open
fix: prevent tab anchor from overriding non-tab URL hashes#204harshitbansal184507 wants to merge 1 commit intopython-poetry:mainfrom
harshitbansal184507 wants to merge 1 commit intopython-poetry:mainfrom
Conversation
harshitbansal184507
force-pushed
the
fix/tabs-anchor-redirect
branch
from
4704924 to
9a50c0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When visiting a URL with a non-tab anchor like
/docs/cli/#add, the tabs controllerwas replacing it with the first tab's ID (e.g.
#script-project) becausefindIndexreturns
-1for no match, which defaults to index0.Added a guard so
showTab()is only called when the anchor actually matches a tab ID.