Always set owner read bit for executable files - #348
Open
ahmojo wants to merge 1 commit into
Open
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes executable file permissions with restrictive umasks.
What changed
make_file_executable()always sets the owner read bit.Why
With a restrictive umask such as
0o777, executable files were chmodded to0o111, leaving the owner unable to read the file. This keeps the existing executable-bit behavior while ensuring owner read permission is present.Tests
uvx nox -s test-3.14 -- --no-cov tests/test_utils.py -k MakeFileExecutableos.umask(0o777)produced0o511uvx nox -s test-3.14uvx 'nox[pbs]' -s lintCloses #140