Skip to content

fix: clamp mingru hidden state before i16 cast #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
decahedron1 merged 1 commit into from
Jul 22, 2026
Merged

fix: clamp mingru hidden state before i16 cast #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/default_predictor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ fn mingru<const IN_DIM: usize>(features: &[i16], h: &mut [i16], weight: &[i16],
// gate is multiplied by 4 then clamped within [0, 1] in Q24
let g = (temp[64 + i] << 2).clamp(0, 16777215) as i64;
let y = (16777215 - g) * ((h[i] as i64) << 9) as i64 + g * temp[i] as i64; // Q24 * Q24 = Q48
h[i] = (y >> 33) as i16; // back down to Q15
h[i] = (y >> 33).clamp(-32768, 32767) as i16; // back down to Q15
}
}

Expand Down