Repository navigation
Don't use the file descriptor size for multipart file lengths - #1320
Open
patrick-immometrica wants to merge 1 commit into
Open
patrick-immometrica wants to merge 1 commit into
patrick-immometrica wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply to a comment to ask cubic a question or push back. It learns from your replies.
View guided diff | Re-trigger cubic
Merging this PR will not alter performance
Comparing Footnotes
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
peek_filelike_length()takesos.fstat().st_sizewhen the object has afileno(). That's wrong for anything whereread()doesn't return the raw file bytes:gzip.open(path, "rb")reports the compressed sizePopen(...).stdout,sys.stdin.buffer) reports 0So
files={"f": gzip.open(...)}sends a too smallContent-Lengthand fails withLocalProtocolError: Too much data for declared Content-Length.This drops the
fstatbranch and keeps thetell()/seek()fallback, the same thing #1214 did forcontent=. Gzip files now get the right length, pipes go out chunked. Regular files are unchanged.Checklist