Skip to content

Parse Digest challenge parameter names case-insensitively - #1315

Merged
Kludex merged 1 commit into
mainfrom
digest-case-insensitive-params
Nov 4, 2026
Merged

Kludex merged 1 commit into
mainfrom
digest-case-insensitive-params

Conversation

@Kludex

@Kludex Kludex commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

Summary

DigestAuth matched challenge parameter names exactly, so Digest Realm="r", Nonce="n" raised ProtocolError, and QOP="auth" or Algorithm=SHA-256 were silently ignored. Whitespace around = also raised. RFC 9110 §11.2 makes auth parameter names case-insensitive and allows whitespace around =.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

AI Disclaimer

This PR was developed with the assistance of either Claude or Codex. I've reviewed and verified the changes.

View guided diff

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T12:08:06.709340Z a89d07f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

View guided diff | Re-trigger cubic

@codspeed

codspeed Bot commented Nov 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 18 untouched benchmarks
⏩ 7 skipped benchmarks1


Comparing digest-case-insensitive-params (a89d07f) with main (ec45c95)

Open in CodSpeed

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Kludex
Kludex merged commit e101f25 into main Nov 4, 2026
18 checks passed
@Kludex
Kludex deleted the digest-case-insensitive-params branch November 4, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant