Repository navigation
Remove unused legacy codecov gem from Gemfile - #299
Merged
Merged
Conversation
Pulling in simplecov/simplecov-console now (module_ci.yml PR #188) also activates puppetlabs_spec_helper's SimpleCov::Formatter::Codecov, since the codecov gem happens to be present. That formatter makes a real synchronous HTTP upload straight to codecov.io's long-deprecated v4/v2 API, which hung for 20+ minutes in the first nightly run after the change landed. The actual coverage upload goes through codecov-action already; HTML/Console formatters alone are enough to produce the resultset.json it reads. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage ? 91.31%
=======================================
Files ? 7
Lines ? 518
Branches ? 0
=======================================
Hits ? 473
Misses ? 45
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
gavindidrichsen
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first nightly run after cat-github-actions#188 merged (setting
SIMPLECOV=yeson the Codecov lane) hung on "Run tests" for 20+ minutes instead of the usual ~10 seconds: https://github.com/puppetlabs/provision/actions/runs/38230880363/job/114749911485 (cancelled).puppetlabs_spec_helper'smodule_spec_helper.rbdoes this wheneverSIMPLECOV=yes:This repo's Gemfile has
gem "codecov", require: false(leftover from an old Travis/.sync.ymlsimplecov: truesetup), so therequiresucceeds and that formatter gets registered. Itsformatmethod makes a real synchronousNet::HTTPcall straight tohttps://codecov.io/upload/v4(falling back to/upload/v2), with retries on timeout/socket errors, and explicitly disables WebMock first so the call isn't stubbed. That legacy direct-upload API was replaced years ago by thecodecovCLI thatcodecov-action@v4already uses — hitting it now appears to hang rather than fail fast, which is what stalled the job.Removing the gem makes that
requireraiseLoadError, which is caught and ignored — SimpleCov just skips that formatter. The HTML + Console formatters still writecoverage/.resultset.json, which is allcodecov-actionneeds.Test plan
🤖 Generated with Claude Code