[isaac-jha]

Problem

tasks/abs.rb set the ABS request priority with:

priority = ENV['CI'] ? 1 : 2

ENV['CI'] is a string, so it is truthy for any value — including "false". Every run under CI (GitHub Actions always sets CI=true, and Litmus/module CI provisions through this task) therefore requested ABS priority 1.

Per the ABS README, "Jobs at Priority 1 ignore max_count" — priority 1 bypasses the pool's anti-swamping cap. So this made CI able to flood ABS and contributed to VM pile-up/orphans.

This is one of the orphan sources tracked in P4DEVOPS-15381 (observed via the complyci-ghactions user used by puppetlabs/comply-e2e).

Fix

priority = ENV['CI'] == 'true' ? 3 : 2

• Guards on the actual value, so CI=false/unset → priority 2.
• CI runs use priority 3 (lowest/default), local/interactive runs use 2. Neither claims priority 1, so both respect max_count.

Tests

Added coverage asserting the posted priority is 3 under CI=true and 2 under CI=false. Full spec/tasks/abs_spec.rb passes locally (13 examples, 0 failures).

Note on reaping

This stops CI from bypassing max_count, but the 12-hour ABS reaper backstop for these requests is being fixed separately in always-be-scheduling (the reaper was scoped only to user == always-be-scheduling). See P4DEVOPS-15381.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Updates ABS provisioning priorities to prevent CI jobs from bypassing pool limits.

Changes:

• Assigns priority 3 to CI requests and 2 otherwise.
• Adds tests for CI=true and CI=false.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
tasks/abs.rb	Updates ABS priority selection.
spec/tasks/abs_spec.rb	Adds priority behavior tests.

Suppressed comments (1)

spec/tasks/abs_spec.rb:143

• This also uses with_env, whose cleanup unconditionally deletes CI rather than restoring the runner's original value. The example therefore leaks a global environment change to later specs. Avoid mutating the real environment here, or make the helper restore each key's previous value.

      with_env('CI' => 'false') do
        expect(abs.task(**params)).to eq({ status: 'ok', nodes: 1 })
      end

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

tasks/abs.rb:43

• AppVeyor CI is still classified as a local run here: this same method explicitly handles AppVeyor with ENV['CI'] == 'True' above, so those requests will receive priority 2 rather than the documented CI priority 3. Compare the value case-insensitively (and add coverage for CI=True) so every supported CI provider gets the capped default priority.

    priority = ENV['CI'] == 'true' ? 3 : 2

[joshcooper]

@isaac-jha could you resolve conflicts?

@actowery could someone take a look at this? Module CI is currently bypassing ABS capacity limits

[Copilot]

🟢 Approval recommended

The priority correction is complete, backward-compatible, and adequately tested.

0 open findings

2 resolved since last review

• with_env deletes the key in its ensure block instead of restoring its prior value. Because CI…
• The task's AppVeyor branch above explicitly recognizes CI == 'True', but this comparison…

🧠 Review effort: Balanced

[david22swan]

@isaac-jha If you could resolve the conflicts we can get this merged

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.31%. Comparing base (0764bdb) to head (f5afde7).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files           7        7           
  Lines         518      518           
=======================================
  Hits          473      473           
  Misses         45       45           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

🟢 Approval recommended

The priority logic is correct, focused, and adequately tested.

0 open findings

🧠 Review effort: Balanced

[LukasAud]

LGTM