Add more Pulp Exceptions.#1440
Conversation
aKlimau
force-pushed
the
add-pulp-exceptions
branch
6 times, most recently
from
61abafd to
26799ca
Compare
aKlimau
force-pushed
the
add-pulp-exceptions
branch
8 times, most recently
from
de94a5e to
b1b54b6
Compare
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
b1b54b6 to
e3388cb
Compare
| Exception Signifying that the Release file contains the 'No-Support-for-Architecture-all' field, | ||
| but with a value other than 'Packages'. We interpret this as an error since this would likely | ||
| signify some unknown repo format, that pulp_deb is more likely to get wrong than right! |
There was a problem hiding this comment.
Not a strong opinion, but I would keep the original class descriptions to ensure that no information was lost.
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
e3388cb to
4c58f8d
Compare
| """ | ||
| Copy content from one repo to another. | ||
|
|
||
| Args: |
There was a problem hiding this comment.
Wow, these look plain wrong...
| @@ -105,7 +106,7 @@ | |||
| ) | |||
|
|
|||
| if dependency_solving: | |||
There was a problem hiding this comment.
Is this something that the api allows in the first place?
I would not change this Exception at all.
If the user can trigger an Unimplemented codepath, that's a server error. And should be prevented/fixed/implemented.
There was a problem hiding this comment.
but does it hurt to let the user know what's caused the error?
Is this something that the api allows in the first place?
I would not change this Exception at all. If the user can trigger an Unimplemented codepath, that's a server error. And should be prevented/fixed/implemented.
There was a problem hiding this comment.
Is there any way the user can trigger this?
There was a problem hiding this comment.
I think the API parameter already exists, and then you will quickly learn not to use it, because it is not implemented and can never work...
There was a problem hiding this comment.
yes, if request for copying for some reason has "dependency_solving" set to true:
dependency_solving = serializers.BooleanField(
help_text=_(
"Also copy dependencies of any packages being copied. NOT YET"
'IMPLEMENTED! You must keep this at "False"!'
),
default=False,
)
There was a problem hiding this comment.
I'm sad now. Anyway, can we handle NotImplementedError generically in core? It looks like there would be a pattern.
Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>
aKlimau
force-pushed
the
add-pulp-exceptions
branch
from
4c58f8d to
d0790a5
Compare
4 participants
Assisted-by: Claude Sonnet 4.6 noreply@anthropic.com
📜 Checklist
See: Pull Request Walkthrough