spyglass: Fix comb-loop in snitch - #168
Open
gbellocchi wants to merge 1 commit into
Open
Conversation
Remove `SameCycleRW` of `cc_passthrough_stream_fifo` instantiated as buffers in `idma_dataflow_element`. This modification breaks a comb-loop found via Spyglass in the Snitch cluster.
gbellocchi
requested review from
DanielKellerM and
thommythomaso
as code owners
August 7, 2026 11:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a combinational loop found via Spyglass into the Snitch cluster. To accomplish this, I deactivated the
SameCycleRWfeature ofcc_passthrough_stream_fifo, which is instantiated as a buffer inidma_dataflow_element.