Skip to content

backend: Fix compute synth-wrapper emission and AXI-write eligibility - #162

Merged
DanielKellerM merged 3 commits into
pulp-platform:develfrom
DanielKellerM:fix/pr159-compute
Jul 31, 2026
Merged

backend: Fix compute synth-wrapper emission and AXI-write eligibility#162
DanielKellerM merged 3 commits into
pulp-platform:develfrom
DanielKellerM:fix/pr159-compute

Conversation

@DanielKellerM

Copy link
Copy Markdown
Collaborator

Follow-up to #159 - review fixes deferred so #159 could land.

  • synth.py: pass compute_eligible so synth wrappers emit the compute params (were silently dropped under Mako non-strict-undefined -> dead synth-wrapper path).
  • util.py: restrict compute write-side to AXI (only idma_axi_write has w_beat_done_o; OBI-write eligible variants had an undriven w_beat_done).
  • idma_transport_layer.sv.tpl: gate the w_beat_done decl, per-port copy, and mux arm to AXI write ports.

Verified (Verilator 5.046): all 8 synth wrappers elaborate; compute-enabled rw_axi and rw_axi_rw_init_rw_obi reach i_idma_otf_compute; non-AXI-write variants drop the dangling w_beat_done.

Copilot AI review requested due to automatic review settings July 31, 2026 08:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@DanielKellerM
DanielKellerM merged commit d079786 into pulp-platform:devel Jul 31, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants