[hardware] Shuffle suppress fix - #483
Open
antellopeTweet wants to merge 2 commits into
Open
Conversation
Shuffle suppression previously occured when: (full vd overwrite) and (vd is a source register) and (vd needs a re-shuffle) Previous implementation identified that source was also vd so suppressed source reshuffle, relying on destination reshuffle, but if vd was fully overwritten it also suppressed destination reshuffle, resulting in no shuffle For example in the following assembly sequence: ```asm vsetvli zero, zero, e64, m8, ta, ma vl8re64.v v8, (lhs) // whole register loads always use ew8 vl8re64.v v16, (rhs) vfsub.vv v8, v8, v16 // v8 is used as source, totally overwritten destination, and needs a shuffle vs8r.v v8, (dst) ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: Shuffle suppressed when required for whole reg read-write
Shuffle suppression previously occured when: (full vd overwrite) and (vd is a source register) and (vd needs a re-shuffle)
Previous implementation identified that source was also vd so suppressed source reshuffle, relying on destination reshuffle, but if vd was fully overwritten it also suppressed destination reshuffle, resulting in no shuffle
For example in the following assembly sequence:
Changelog
Fixed
Checklist