fix(vstu): Compare counters instead of pointers in B handling - #481
Merged
Conversation
creinwar
marked this pull request as ready for review
August 5, 2026 20:02
Navaneeth-KunhiPurayil
approved these changes
Aug 6, 2026
Navaneeth-KunhiPurayil
left a comment
Navaneeth-KunhiPurayil
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks!
Collaborator
|
LGTM! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a subtle bug in the vector store unit, which can deadlock Ara if all store instructions in the queue are issued before any of them get committed.
Changelog
Fixed
issue_pntisVInsnQueueDepthinstructions ahead ofcommit_pnt(i.e.,issue_pnt == commit_pntbutissue_cnt == '0andcommit_cnt == VInsnQueueDepth).Checklist