Add support for multiple key-value stores.#98
Open
PiotrSikora wants to merge 4 commits into
Open
Conversation
While there, add and consistently use `UNKNOWN_RESOURCE_ID` error for when resources are accessed using an unknown ID. Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
Member
Author
leonm1
approved these changes
May 21, 2026
leonm1
reviewed
May 21, 2026
|
|
||
| * params: | ||
| - `i32 (const char*) kvstore_name_data` | ||
| - `i32 (size_t) kvstore_name_size` |
Contributor
There was a problem hiding this comment.
I think we decided that we wanted to add a return argument to indicate if the kvstore already existed or was created (to permit one-time initialization scripts to run)
From the March 19th proxy-wasm meeting.
Contributor
There was a problem hiding this comment.
Maybe we could add an ALREADY_EXISTS value to the proxy_status_t enum?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.