Repository navigation
Conversation
The riscv64 builds were silently failing because Makefile.common drops exit status there. This causes issues with manifest creation, and causes the job to fail for riscv64, and then also block releases for s390x as collateral. From the `Publish default branch artifacts` job in run `36956974726`: ``` ERROR: failed to build: ... "/.build/linux-riscv64/prometheus-mcp": not found An image does not exist locally with the tag: prom/prometheus-mcp-linux-riscv64 no such manifest: docker.io/prom/prometheus-mcp-linux-riscv64:main manifest unknown (ghcr.io pass, same point) ``` Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The riscv64 builds were silently failing because Makefile.common drops
exit status there. This causes issues with manifest creation, and causes
the job to fail for riscv64, and then also block releases for s390x as
collateral.
From the
Publish default branch artifactsjob in run36956974726:Signed-off-by: TJ Hoplock t.hoplock@gmail.com