Fix #158#165
Open
RoiArthurB wants to merge 6 commits into
Open
Conversation
- Add alias `GAMALESS` to `ENV_GAMALESS`
Avoid having to connect to random `adb-2G0YC1ZF8Q05RW-KEQjyK._adb-tls-connect._tcp`
…starts Fixes #156 — Unity preview failed when GAMA was started before the WebPlatform: 'do create_player(...)' hit 'nil value detected' and the player was permanently stuck in a dead loop. Root causes: - experiment_id/experiment_state were blindly poisoned by any SimulationStatus, even for experiments the platform never launched - the authoritative experiment id returned by the 'load' ack was misstored as experiment_name and never used - in_game was committed before GAMA acked create_player, so one failure permanently suppressed retries Fix (verified against a live GAMA GUI-server): - Track experiment ownership: experiment_id is only set from our own load ack or a successful probe adoption - Probe proactively on ConnectionSuccessful (GAMA never re-broadcasts SimulationStatus to new clients) with 'string(paused)+"|"+string(cycle)': fails exactly when no live simulation exists, and carries the real RUNNING/PAUSED state on success - Adopt usable pre-existing experiments (players auto-join, platform restart mid-session now recovers); reject unusable ones silently on connect, with a monitor warning flag once a status proves one exists - Re-probe rejected experiments on a RUNNING transition (user pressed play in the GAMA GUI) - Roll back in_game and notify the Unity client with an explicit error when GAMA rejects create_player, so the player can retry later - Gate all outgoing commands (create/remove player, expression, ask) behind canTalkToExperiment() Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ApEsviNMJxKePdy4gQjxag
…ntrol Show an orange banner on the SimulationManager screen when the backend flags foreign_experiment_detected (see #156): GAMA has an experiment opened from its own interface that the platform cannot use. Translated in all six languages. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ApEsviNMJxKePdy4gQjxag
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Checklist
Description
Related Issue
#158