Skip to content

support bigdecimal 4.1 - #118

Closed
denysivanov wants to merge 1 commit into
prawnpdf:masterfrom
rubris-inc:start-to-support-bigdecimal-4.1
Closed

support bigdecimal 4.1#118
denysivanov wants to merge 1 commit into
prawnpdf:masterfrom
rubris-inc:start-to-support-bigdecimal-4.1

Conversation

@denysivanov

Copy link
Copy Markdown

No description provided.

@fillipeppalhares

Copy link
Copy Markdown

any prevision for this PR?

@denysivanov

Copy link
Copy Markdown
Author

@fillipeppalhares

any prevision for this PR?

Can't predict here.
I had an issue and addressed it but I do not have rights to merge.

@pointlessone

Copy link
Copy Markdown
Member

What is the rationale behind this PR? What issue does it solve?

@larskanis

Copy link
Copy Markdown

It is probably is meant to address #108, #110, #110, #115, but that is already fixed by #114.

@pointlessone What it needed instead is a new release with the fix in #114. Could you please get it out?

@hoshy

hoshy commented May 7, 2026

Copy link
Copy Markdown

+1 from another downstream consumer — we have an open bundle update PR sitting blocked on this. The fix in #114 is already on master; it's just waiting on a tagged release so we can lift our bigdecimal "~> 3.1" pin and move to Ruby 4's bundled 4.1.0.

Any chance of cutting a 1.8.1 / 1.9.0? Happy to verify against a pre-release first if that helps.

@denysivanov denysivanov closed this May 7, 2026
@hoshy

hoshy commented May 13, 2026

Copy link
Copy Markdown

@denysivanov why is this closed?

@denysivanov

Copy link
Copy Markdown
Author

@hoshy those changes already was implemented in other PR and merged in main

here is commit
ad8367a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants