Repository navigation
Pin manifest-builder to exactly 0.7.14 - #107
Merged
Merged
Conversation
A relock would otherwise take any newer release, and 0.8.0 will drop the deploy-id relcoord still depends on. The generated manifests depend on the builder version too, so moving it should be a deliberate change of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
manifest-builder>=0.7.13would accept 0.8.0 on any relock (uv lock --upgrade, Renovate, a dependency sweep). 0.8.0 (PortSwigger/manifest-builder#149) dropsGenerationResult.deploy_id, so relcoord main would then fail every change with deployment detection on. It needs the code in #106 to go with that version.Pinning exactly also means builder upgrades, which change the generated manifests, only happen in a PR meant for them.
Lock unchanged apart from the specifier; still resolves 0.7.14. All 469 tests pass with
uv sync --locked.